Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4221 closed defect (fixed)

Startup performance decreased since build 2.7.3.4186

Reported by: arthur Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, mapx Blocked By:
Blocking: #521 Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29347265/

Description

Environment

Windows 10 Pro
Firefox Nightly 50.0a1 (20160701030235)
ABP 2.7.3.4186
EasyList

How to reproduce

  1. Subscribe to EasyList Germany, EasyPrivacy and Fanboy's Social Blocking List (issue seems more noticeable with more filter lists).
  2. Close Nightly and start it again
  3. Click the menu bottom immediately after starting and start hovering different buttons so you see them being highlighted

Observed behaviour

With ABP 2.7.3.4186 it takes some seconds until you see the defferent buttons being highlighted when hovering.

Expected behaviour

It shouldn't take this long. With 2.7.3.4185 it's noticeably shorter with the same configuration.

Change History (9)

comment:1 Changed 3 years ago by mapx

  • Cc mapx added

comment:3 Changed 3 years ago by trev

  • Owner set to trev
  • Priority changed from Unknown to P1
  • Ready set

As it is with performance issues, I cannot be sure that the issue I found is the one that the reporter saw. I see however lots of "elemhideupdate" messages being sent to the content process - one for every filter added. This causes noticeable slowdown and is completely unnecessary, one such message would have been sufficient.

Last edited 3 years ago by trev (previous) (diff)

comment:4 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by trev

  • Blocking 521 added

comment:7 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Please retest whether you can still see this issue with build Adblock Plus 2.7.3.4189.

comment:8 Changed 3 years ago by arthur

I no longer notice the mentioned performance issues with 2.7.3.4189.

comment:9 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Did not notice any startup performance issues.

ABP 2.7.3.4198-beta
Nightly 51.0a1 / Windows 10
Firefox 48 / Windows 7

Note: See TracTickets for help on using tickets.