Opened 3 years ago

Closed 3 years ago

#4239 closed change (fixed)

Change indentation to reflect our coding style

Reported by: rjeschke Assignee: asmirnov
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29348972/

Description

Background

We do use two-space indentation for Java and C++ source files.

What to change

Correct the indentation in all necessary files.

Change History (5)

comment:1 Changed 3 years ago by asmirnov

Probably i've missed something:
https://adblockplus.org/en/coding-style "Follow the Mozilla Coding Style's Java practices"
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Java_practices "4-space indents"

should they be 2 or 4 spaces eventually?

comment:2 Changed 3 years ago by rjeschke

It is two spaces, we use two spaces nearly everywhere here. Either this was not corrected in the beginning by us, or the coding style was changed by Mozilla. We will need to update our coding style guide and remove the links to Mozilla's.

comment:3 Changed 3 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4239 - Change indentation to reflect our coding style

comment:5 Changed 3 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.