Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4251 closed defect (fixed)

Adblock Plus hangs trying to apply element hiding rules to blocked frames

Reported by: mapx Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, greiner Blocked By:
Blocking: #4211 Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29348026/

Description (last modified by trev)

Environment

windows 7 / 10
FF 48.0b7
ABP dev build 2.7.3.4194
easylist

How to reproduce

  1. Go to https://www.rt.com/op-edge/345470-nsa-leaks-snowden-whistleblower/
  2. Wait a bit and check the CPU usage.
  3. Close Firefox.

Expected results

CPU usage is low after the page is loaded, Firefox shuts down correctly.

Actual results

High CPU usage, Firefox hangs instead of shutting down.

Background

This seems to be triggered by us blocking the frame. On this particular page the AddThis frame is blocked. Consequently, its contents don't load - the document remains in the "uninitialized" state forever which causes an infinite loop with the changes from #4211.

Change History (14)

comment:1 Changed 3 years ago by mapx

  • Description modified (diff)

comment:2 Changed 3 years ago by mapx

  • Description modified (diff)
  • Summary changed from high CPU usage dev build 2.7.3.4194 to (high CPU usage) + (crash on closing FF) dev build 2.7.3.4194

comment:3 Changed 3 years ago by mapx

  • Description modified (diff)

comment:4 Changed 3 years ago by trev

Which website are we talking about? I guess that it is some Google search page with Acceptable Ads disabled?

comment:5 Changed 3 years ago by mapx

it's google.com but it does not matter: every site will generate the same behaviour
acceptable ads disabled

Last edited 3 years ago by mapx (previous) (diff)

comment:6 Changed 3 years ago by mapx

well, not every site ... but if the behaviour starts on google.com for example ... but changing the page the high cpu usage will still remain ON

comment:7 Changed 3 years ago by trev

  • Blocking 4211 added
  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

Never mind, I was able to reproduce this behavior so I see the problem...

comment:8 Changed 3 years ago by trev

  • Description modified (diff)

comment:9 Changed 3 years ago by trev

  • Summary changed from (high CPU usage) + (crash on closing FF) dev build 2.7.3.4194 to Adblock Plus hangs trying to apply element hiding rules to blocked frames

comment:10 Changed 3 years ago by trev

  • Owner set to trev

comment:11 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:13 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

CPU usage no longer looks excessive and Firefox shuts down correctly.

ABP 2.7.3.4197-beta
Firefox 38 / 45 / 49.0b1 / Windows 7

Note: See TracTickets for help on using tickets.