Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4255 closed change (fixed)

Place Element Hiding Helper button in the DevTools toolbar if one exists

Reported by: trev Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.9
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29348056/

Description

Background

Element Hiding Helper will currently insert its button before the breadcrumbs in the Inspector panel. However, in Firefox 48 the breadcrumbs were moved to the bottom, and now we have element overlapping issues.

What to change

Move the icon back to the main toolbar, insert it after the "Create New Node" button which was also added in Firefox 48. Keep the original logic for older Firefox versions.

Change History (4)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • In Firefox 47 and below the ABP icon in Inspect Element remains in front of the breadcrumbs toolbar.
  • In Firefox 48 and up, the ABP icon sits just after the '+' icon (Create a new node). As stated above, the breadcrumbs toolbar now sits at the bottom of the inspector.

Version 1.3.8.536-beta
Firefox: (38, 42, 47) - (48.0b10 Beta, 49.0a2 - Development, 50.0a1 - Nightly)

Note: See TracTickets for help on using tickets.