Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4256 closed change (fixed)

Element Hiding Helper should use larger ABP icon on high-DPI screens

Reported by: trev Assignee: trev
Priority: P3 Milestone: Element-Hiding-Helper-1.3.9
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29348059/

Description

Background

Element Hiding Helper will currently use the 16x16 icon in the Inspector panel of Developer Tools. On high-DPI screens this is suboptimal.

What to change

Use larger icon depending on pixel density.

Attachments (4)

EHH New 150%.PNG (20.8 KB) - added by scheer 3 years ago.
EHH New 200%.PNG (62.0 KB) - added by scheer 3 years ago.
EHH Old 150%.PNG (18.5 KB) - added by scheer 3 years ago.
EHH Old 200%.PNG (50.6 KB) - added by scheer 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • The EHH icon now scales correctly dependent on the DPI scale set. A huge difference can be noted between the versions as depicted in the images attached.

EHH New - 1.3.8.536-beta
EHH Current - 1.3.8 (Live Version)
Firefox 45, 48
Windows 10 64 Bit

Changed 3 years ago by scheer

Changed 3 years ago by scheer

Changed 3 years ago by scheer

Changed 3 years ago by scheer

Note: See TracTickets for help on using tickets.