Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4260 closed change (rejected)

Replace Apache Commons Lang classes

Reported by: asmirnov Assignee: asmirnov
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: rjeschke, fhd Blocked By: #4030
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29348632/

Description

Background

Currently we're using Apache Commons Lang classes in libadblockplus-android (https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-android/src/org/apache/commons/lang) and adblockplusandroid (https://hg.adblockplus.org/adblockplusandroid/file/tip/src/org/apache/commons/lang).

We need to rewrite it because of possible licensing issue and codestyle (discussed with Rene).

What to change

org/apache/commons/lang classes.

Also we need to investigate if it's used in library or proxy app only and possibly move it to proxy app repo.

Change History (3)

comment:1 Changed 3 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by asmirnov

  • Resolution set to rejected
  • Status changed from reviewing to closed

comment:3 Changed 3 years ago by asmirnov

since proxy app is not supported any more there is no need to implement the changes.

Note: See TracTickets for help on using tickets.