Opened 3 years ago

Closed 2 years ago

#4264 closed change (fixed)

Handle actions in a more centralized way

Reported by: greiner Assignee: saroyanm
Priority: P3 Milestone:
Module: User-Interface Keywords: a11y, new-settings-page
Cc: saroyanm Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29373665/

Description (last modified by greiner)

Background

To stop any further and reduce existing code duplication we should centralize the execution of UI actions used in the global handlers for "keyup" and "click" events.

What to change

  • Centralize execution of actions such as "open-doclink" and use it in the global handlers for the "keyup" and "click" events.
  • When a link is focused and the Enter key is pressed it should execute all actions that are assigned to it.

Change History (9)

comment:1 Changed 3 years ago by greiner

  • Owner set to greiner

comment:2 Changed 3 years ago by saroyanm

  • Description modified (diff)
  • Keywords new-settings-page added

@greiner I've updated the ticket as we discussed together, I noticed that the ticket is assigned to you. Can you please remove assignment if you are not working/planing to work in near future.

comment:3 Changed 3 years ago by saroyanm

  • Cc saroyanm added

comment:4 Changed 3 years ago by saroyanm

  • Owner changed from greiner to saroyanm

comment:5 Changed 3 years ago by greiner

  • Description modified (diff)
  • Summary changed from Make sure to include all links in tab order in new options page to Handle actions in a more centralized way

comment:6 Changed 3 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 2 years ago by wspee

  • Blocking 5158 added; 2407 removed

As this will still be implemented in the new new options page I changed it to block #5158 instead.

comment:8 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
issue 4264 - centralize action handling

comment:9 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.