Changes between Initial Version and Version 2 of Ticket #4264


Ignore:
Timestamp:
01/24/2017 10:28:05 AM (4 years ago)
Author:
saroyanm
Comment:

@greiner I've updated the ticket as we discussed together, I noticed that the ticket is assigned to you. Can you please remove assignment if you are not working/planing to work in near future.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4264

    • Property Owner set to greiner
    • Property Keywords new-settings-page added
  • Ticket #4264 – Description

    initial v2  
    11=== Background === 
    2 There's one link in the new options page that cannot be reached via keyboard because it's not focusable. Therefore we should include it in the tab order and make it possible to interact with via keyboard. 
    3  
    42Additionally, to stop any further and reduce existing code duplication it'd be advisable to centralize the execution of UI actions used in the global handlers for "keyup" and "click" events. 
    53 
    64=== What to change === 
    7 - Add `tabindex="0"` to the link with the text "edit your filter list" in the Advanced tab. 
    85- When the link is focused and the Enter key is pressed it should execute both actions that are assigned to it. 
    96- Centralize execution of actions such as "open-doclink" and use it in the global handlers for the "keyup" and "click" events.