Opened 4 years ago

Last modified 3 years ago

#4264 closed change

Make sure to include all links in tab order in new options page — at Version 2

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords: a11y, new-settings-page
Cc: saroyanm Blocked By:
Blocking: #2407 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29373665/

Description (last modified by saroyanm)

Background

Additionally, to stop any further and reduce existing code duplication it'd be advisable to centralize the execution of UI actions used in the global handlers for "keyup" and "click" events.

What to change

  • When the link is focused and the Enter key is pressed it should execute both actions that are assigned to it.
  • Centralize execution of actions such as "open-doclink" and use it in the global handlers for the "keyup" and "click" events.

Change History (2)

comment:1 Changed 4 years ago by greiner

  • Owner set to greiner

comment:2 Changed 4 years ago by saroyanm

  • Description modified (diff)
  • Keywords new-settings-page added

@greiner I've updated the ticket as we discussed together, I noticed that the ticket is assigned to you. Can you please remove assignment if you are not working/planing to work in near future.

Note: See TracTickets for help on using tickets.