Opened 3 years ago

Closed 21 months ago

#4275 closed change (fixed)

Remove the adblockplus dependency from adblockpluschrome

Reported by: fhd Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-3.0-for-Firefox
Module: Platform Keywords:
Cc: kzar, sebastian, trev, greiner Blocked By: #4829
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)

Background

After the core code was moved from the adblockplus to the adblockpluscore repository, we had to update repositories depending on the adblockplus repository accordingly. #2597 was about doing that in adblockpluschrome. However, the adblockplus dependency was left behind, because some strings from the repository are still being imported.

What to change

Completely remove the adblockplus dependency from the adblockpluschrome repository. In order to do that, the remaining strings imported from adblockplus should be moved into adblockpluschrome.

Look at the [import_locales] section of adblockpluschrome/metadata.chrome to see which imported strings need to be moved. Before moving these strings please ensure they are still used. Perhaps some of them are no longer needed and can be simply removed.

Change History (8)

comment:1 Changed 3 years ago by kzar

  • Cc sebastian added; snoack removed
  • Description modified (diff)
  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed 3 years ago by greiner

  • Cc greiner added

comment:3 Changed 3 years ago by greiner

Note that some of the strings already exist in adblockplusui due to the new options page so we should avoid duplicating those when moving them over.

comment:4 Changed 21 months ago by sebastian

  • Description modified (diff)
  • Priority changed from P4 to P3

Since adblockplus (the legacy Gecko extension) is deprecated now, I think it will be simpler to just move the strings (which aren't directly used by adblockplusui), into adblockpluschrome instead. I updated the issue description accordingly.

comment:5 Changed 21 months ago by kzar

  • Blocked By 4829 added

comment:6 Changed 21 months ago by sebastian

  • Owner set to sebastian

comment:8 Changed 21 months ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-next
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.