Opened 3 years ago

Closed 2 years ago

#4292 closed change (rejected)

gDevTools.jsm is deprecated, replace it in Element Hiding Helper by loading the CommonJS module

Reported by: trev Assignee:
Priority: P3 Milestone:
Module: Extensions-for-Adblock-Plus Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

As of bug 1188405 (Firefox 47) the recommended way to access developer tools is no longer loading gDevTools.jsm, it is merely kept around for backwards compatibility. There is devtools/client/framework/devtools CommonJS module instead exposing gDevTools variable.

What to change

We should get the DevTools CommonJS environment and load that CommonJS module the way gDevTools.jsm currently does it. If that fails we should still fall back to loading gDevTools.jsm, for older Firefox versions.

Change History (1)

comment:1 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.

Note: See TracTickets for help on using tickets.