Opened 17 months ago

Closed 14 months ago

Last modified 14 months ago

#4295 closed change (fixed)

Update adblockplusui dependency to revision 53626d2055a6

Reported by: greiner Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: kzar, sebastian Blocked By: #4294
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29356618/

Description (last modified by greiner)

Background

This dependency update should import the removal of the features section from the first-run page (see #4294).

Further imports will be for changes related to the new options page and should therefore have no impact: #2377, #2409, #2802, #2358 #3741, #3885, #3895, #3905, #3907, #3968, #3971

Other changes:

  • #3952 - Fix whitespaces in Python code for compliance with PEP-8
  • #3999 - Response to filters.get/cssproperties message should contain filter text
  • #4201 - CSS property filter still applied when ABP is disabled everywhere
  • #4297 - "filterlistsReinitialized" test parameter broken

What to change

Remove imports from /skin/features/. This directory and its content no longer exist.

Change History (6)

comment:1 Changed 16 months ago by greiner

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency from revision 0593d76f1106 to Update adblockplusui dependency to revision 53626d2055a6

comment:2 Changed 14 months ago by kzar

  • Cc kzar sebastian added
  • Owner set to kzar
  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 14 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 4295 - Update adblockplusui dependency

comment:5 Changed 14 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 14 months ago by rraceanu

  • Verified working set

Features on first-run page removed, verified on ABP version 1.12.2.1670, Chrome 41,45,51,54 Opera 35, 40 and Safari 7, 9.

Last edited 14 months ago by rraceanu (previous) (diff)
Note: See TracTickets for help on using tickets.