Opened 3 years ago

Last modified 3 years ago

#4298 closed defect

Unblockable ad box on Slickdeals.net — at Version 5

Reported by: rhana@… Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.12.2-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: kzar, sebastian, mapx, Ross, scheer Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29349024/

Description (last modified by kzar)

Environment

Windows 10 Home, 64-bit running on a Dell Dimension XPS
Chrome 52.0.2743.82 m (fully up-to-date)
AdBlock 3.1 with AdBlock Custom, EasyList, Malware Protection, Acceptable Ads disabled; filter lists updated today
ABP 1.12.1 with EasyList, Acceptable Ads disabled; filter lists updated today

How to reproduce

  1. Browse to http://slickdeals.net/
  2. Look for the ad box on the right side of the window near the top.

Observed behaviour

There's a Google AdSense ad.

Expected behaviour

There should be no Google AdSense ads with Acceptable Ads disabled.

Notes

Change History (5)

comment:1 Changed 3 years ago by mapx

  • Cc kzar sebastian mapx added

comment:2 Changed 3 years ago by mapx

@Rhana, did you ask your developers (adblock 3.1 on chrome) about this issue ? :)

comment:3 Changed 3 years ago by kzar

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Owner set to kzar
  • Platform changed from Chrome to Unknown / Cross platform
  • Priority changed from Unknown to P2
  • Ready set

Can reproduce as described, investigating.

comment:4 Changed 3 years ago by kzar

Looks like they're messing with our element hiding styles, our sheet is still there with all the rules, but the rules no longer have the display: none style. Continuing to investigate...

comment:5 Changed 3 years ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Yep, have come up with a way to make sure display: none isn't tampered with. Works fine for Slickdeals, I'm seeing no ads there now.

Note: See TracTickets for help on using tickets.