Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#432 closed change (fixed)

Adjust to $sitekey-related changes of the Matcher API (Firefox)

Reported by: trev Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-2.6.5-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #406 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4559243822759936/

Description

Background

#431 changes the Matcher API that should make it simpler to implement $sitekey functionality in Firefox.

What to change

Remove Matcher.matchesByKey() call in lib/contentPolicy.js, this check should be covered by the Policy.isWhitelisted() call. This requires verifying the sitekey in advance of course and passing it to that function.

Change History (8)

comment:1 Changed 5 years ago by fhd

  • Priority changed from P1 to P2

comment:2 Changed 5 years ago by greiner

  • Owner set to greiner

comment:3 Changed 5 years ago by philll

  • Platform set to Firefox

comment:4 Changed 5 years ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 5 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:7 Changed 5 years ago by trev

  • Blocked By 1381 added

comment:8 Changed 5 years ago by trev

  • Blocked By 1381 removed
Note: See TracTickets for help on using tickets.