Opened 3 years ago

Last modified 4 months ago

#4321 new change

[abp2blocklist] Improve abp2blocklist to support/patch rules which can't be properly translated from Easylist

Reported by: mario Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords: abp2blocklist
Cc: kzar, sebastian, fhd, mjethani, sporz, dzhang, jsonesen, arthur Blocked By: #3241, #4326, #4327, #4329
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

ABP for Safari on OS X (#3687) as well as ABP for Safari on iOS (#3093) utilize Apple's new content blocking filter list format for content blocking. On OS X this feature is experimental whereas on iOS it's the only available filter list format.
These filter lists are generated by abp2blocklist.

On both platforms, using those content blocking filter lists, we have multiple instances of erroneous filters which result in false positives, blocked acceptable ads or visible ads whereas those errors can't be reproduced using the original source filter lists (tested only via Easylist).

A list of known problems due to the new filter list format can be found here, containing individual ways of reproduction. Please note that this list is not complete, as only Acceptable Ads have been tested thus far.

Want to change

To be defined. Possible options would for example be to improve list generation or to introduce a patch file which is applied to any generated list containing individual fixes.

Change History (20)

comment:1 Changed 3 years ago by kzar

  • Blocked By 4326 added

comment:2 Changed 3 years ago by sebastian

  • Blocked By 3241 added
  • Cc sebastian added

I think the first thing we should do here is generating a new blocking list (using the latest version of our filter lists and abp2blocklist) and re-run the Acceptable Ads tests. I'm positive that this will already fix a fair amount of issues, probably not all though. But that is something we can look into then.

FWIW, applying changes to the generated list is only a last resort. But I agree, if there is no way around, we need a more structured way than how we do it right now, and one that also considers Adblock Plus for Safari on OS X.

Last edited 3 years ago by sebastian (previous) (diff)

comment:3 Changed 3 years ago by kzar

Just to add to what Sebastian said, we made an improvement to abp2blocklist today in issue #4326 which should improve things quite a bit. I know that you guys had a test this / last week, but it might be worth regenerating the rules with the latest abp2blocklist and testing again.

comment:4 Changed 3 years ago by kzar

  • Blocked By 4327 added

comment:5 Changed 3 years ago by kzar

  • Blocked By 4329 added

comment:6 Changed 3 years ago by mario

@sebastian, @kzar, this issue was opened after we gave content blocking a try using a completely new content blocking list generated via abp2blocklist. The new list resolved some of the existing issues, but also introduced a lot more problems. The results can be found here* (column BB).
However we'll give it another try now that #4326 is closed. I will report back with the results.

*This document is not public - I'll attach a file containing the results later.

Last edited 3 years ago by mario (previous) (diff)

comment:7 Changed 3 years ago by fhd

  • Cc fhd added

comment:8 Changed 3 years ago by kzar

  • Keywords abp2blocklist added

comment:9 Changed 2 years ago by kzar

  • Cc mjethani added

comment:10 Changed 2 years ago by mjethani

  • Owner set to mjethani

comment:11 Changed 2 years ago by sporz

  • Cc sporz added

comment:12 Changed 22 months ago by dzhang

  • Cc dzhang added

comment:13 Changed 17 months ago by mjethani

  • Owner mjethani deleted

While I would love to work on this, in terms of priorities it looks like I just won't be able to give any time to this as it is not (directly) related to circumvention.

Removing myself as the owner so someone else can look into it.

comment:14 Changed 17 months ago by mjethani

  • Cc jsonesen added

comment:15 Changed 17 months ago by dzhang

  • Owner set to dzhang

I'll investigate what can be done about this.

comment:16 Changed 17 months ago by arthur

  • Cc arthur added

comment:17 Changed 17 months ago by dzhang

comment:18 Changed 17 months ago by kzar

Why track changes to the abp2blocklist repository under a GitLab board for the sandbox repository, especially when the changes already have issues in the issue tracker currently used by the Platform module which abp2blocklist comes under?

As it happens we already have a Hub issue open for moving some of the other Platform (and Automation) repositories over to GitLab, would you like me to request abp2blocklist is included in that migration?

comment:19 Changed 17 months ago by sebastian

With Adblock Plus for Safari (legacy extension) on the way out, and Adblock Plus for iOS/macOS being the only consumer left of abp2blocklist, I'd like to transfer the repository to the "Adblock Plus for iOS/macOS" module (leaving it up to the new module owner whether to move it to GitLab).

comment:20 Changed 16 months ago by sebastian

  • Component changed from Platform to Adblock-Plus-for-iOS
Note: See TracTickets for help on using tickets.