Opened on 08/10/2016 at 03:29:19 PM

Last modified on 07/04/2019 at 08:56:55 AM

#4321 new change

[abp2blocklist] Improve abp2blocklist to support/patch rules which can't be properly translated from Easylist

Reported by: mario Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords: abp2blocklist
Cc: kzar, sebastian, fhd, mjethani, sporz, dzhang, jsonesen, arthur Blocked By: #3241, #4326, #4327, #4329
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



ABP for Safari on OS X (#3687) as well as ABP for Safari on iOS (#3093) utilize Apple's new content blocking filter list format for content blocking. On OS X this feature is experimental whereas on iOS it's the only available filter list format.
These filter lists are generated by abp2blocklist.

On both platforms, using those content blocking filter lists, we have multiple instances of erroneous filters which result in false positives, blocked acceptable ads or visible ads whereas those errors can't be reproduced using the original source filter lists (tested only via Easylist).

A list of known problems due to the new filter list format can be found here, containing individual ways of reproduction. Please note that this list is not complete, as only Acceptable Ads have been tested thus far.

Want to change

To be defined. Possible options would for example be to improve list generation or to introduce a patch file which is applied to any generated list containing individual fixes.

Attachments (0)

Change History (20)

comment:1 Changed on 08/12/2016 at 01:21:54 PM by kzar

  • Blocked By 4326 added

comment:2 Changed on 08/12/2016 at 03:51:10 PM by sebastian

  • Blocked By 3241 added
  • Cc sebastian added

I think the first thing we should do here is generating a new blocking list (using the latest version of our filter lists and abp2blocklist) and re-run the Acceptable Ads tests. I'm positive that this will already fix a fair amount of issues, probably not all though. But that is something we can look into then.

FWIW, applying changes to the generated list is only a last resort. But I agree, if there is no way around, we need a more structured way than how we do it right now, and one that also considers Adblock Plus for Safari on OS X.

Last edited on 08/12/2016 at 05:55:59 PM by sebastian

comment:3 Changed on 08/12/2016 at 05:53:37 PM by kzar

Just to add to what Sebastian said, we made an improvement to abp2blocklist today in issue #4326 which should improve things quite a bit. I know that you guys had a test this / last week, but it might be worth regenerating the rules with the latest abp2blocklist and testing again.

comment:4 Changed on 08/13/2016 at 04:35:56 PM by kzar

  • Blocked By 4327 added

comment:5 Changed on 08/14/2016 at 09:24:04 AM by kzar

  • Blocked By 4329 added

comment:6 Changed on 08/15/2016 at 09:34:30 AM by mario

@sebastian, @kzar, this issue was opened after we gave content blocking a try using a completely new content blocking list generated via abp2blocklist. The new list resolved some of the existing issues, but also introduced a lot more problems. The results can be found here* (column BB).
However we'll give it another try now that #4326 is closed. I will report back with the results.

*This document is not public - I'll attach a file containing the results later.

Last edited on 08/15/2016 at 09:36:58 AM by mario

comment:7 Changed on 09/16/2016 at 07:29:04 AM by fhd

  • Cc fhd added

comment:8 Changed on 09/16/2016 at 10:50:11 AM by kzar

  • Keywords abp2blocklist added

comment:9 Changed on 05/29/2017 at 04:13:36 PM by kzar

  • Cc mjethani added

comment:10 Changed on 06/16/2017 at 12:03:12 PM by mjethani

  • Owner set to mjethani

comment:11 Changed on 11/23/2017 at 09:59:22 AM by sporz

  • Cc sporz added

comment:12 Changed on 01/17/2018 at 02:26:49 AM by dzhang

  • Cc dzhang added

comment:13 Changed on 06/11/2018 at 12:57:03 PM by mjethani

  • Owner mjethani deleted

While I would love to work on this, in terms of priorities it looks like I just won't be able to give any time to this as it is not (directly) related to circumvention.

Removing myself as the owner so someone else can look into it.

comment:14 Changed on 06/11/2018 at 12:57:23 PM by mjethani

  • Cc jsonesen added

comment:15 Changed on 06/13/2018 at 01:11:46 AM by dzhang

  • Owner set to dzhang

I'll investigate what can be done about this.

comment:16 Changed on 06/15/2018 at 11:41:27 AM by arthur

  • Cc arthur added

comment:17 Changed on 07/04/2018 at 05:42:47 AM by dzhang

comment:18 Changed on 07/04/2018 at 10:30:04 AM by kzar

Why track changes to the abp2blocklist repository under a GitLab board for the sandbox repository, especially when the changes already have issues in the issue tracker currently used by the Platform module which abp2blocklist comes under?

As it happens we already have a Hub issue open for moving some of the other Platform (and Automation) repositories over to GitLab, would you like me to request abp2blocklist is included in that migration?

comment:19 Changed on 07/04/2018 at 02:57:35 PM by sebastian

With Adblock Plus for Safari (legacy extension) on the way out, and Adblock Plus for iOS/macOS being the only consumer left of abp2blocklist, I'd like to transfer the repository to the "Adblock Plus for iOS/macOS" module (leaving it up to the new module owner whether to move it to GitLab).

comment:20 Changed on 07/10/2018 at 03:57:59 PM by sebastian

  • Component changed from Platform to Adblock-Plus-for-iOS

Add Comment

Modify Ticket

Change Properties
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from dzhang.
Next status will be 'reviewing'.
Note: See TracTickets for help on using tickets.