Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#433 closed change (fixed)

Adjust to $sitekey-related changes of the Matcher API (Platform)

Reported by: trev Assignee: greiner
Priority: P2 Milestone: Adblock-Plus-1.8.6-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: #406, #1328 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5644946291818496/

Description

Background

#431 changes the Matcher API that should make it simpler to implement $sitekey functionality in Chrome/Opera/Safari.

What to change

Function processKeyException() in lib/whitelisting.js will currently mark the entire frame as whitelisted if it sees a valid signature and a matching filter. Rather than doing this it should merely verify the signature and record the key for the frame. That key can later be passed in to Matcher.matchesAny() call in webRequest.js.

Change History (6)

comment:1 Changed 6 years ago by fhd

  • Priority changed from P1 to P2

comment:2 Changed 5 years ago by greiner

  • Blocking 1328 added

comment:3 Changed 5 years ago by greiner

  • Platform set to Unknown
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 years ago by greiner

  • Owner set to greiner

comment:5 Changed 5 years ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 5 years ago by greiner

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
Note: See TracTickets for help on using tickets.