Opened on 08/15/2016 at 01:09:27 PM

Closed on 08/16/2016 at 08:22:29 AM

Last modified on 08/22/2016 at 11:55:16 AM

#4331 closed defect (fixed)

Wrapped WebSocket has wrong constructor signature

Reported by: trev Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-1.12.2-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, kzar, Ross, scheer Blocked By:
Blocking: #1727 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):



Adblock Plus on Chrome 52.

How to reproduce

  1. Go to
  2. Press Ctrl-Shift-J/Cmd-Option-J to open JavaScript console.
  3. Type WebSocket.length and press Enter.

Observed behaviour

You see 2 being printed to console.

Expected behaviour

It should be 1, as you get on the new tab page where WebSocket isn't wrapped.

Our wrapper should only have one parameter, the second parameter should be accessed as arguments[1] rather than by name.

Attachments (0)

Change History (6)

comment:1 Changed on 08/15/2016 at 07:31:25 PM by kzar

  • Owner set to kzar
  • Priority changed from Unknown to P1
  • Ready set
  • Review URL(s) modified (diff)

comment:2 Changed on 08/15/2016 at 07:31:34 PM by kzar

  • Status changed from new to reviewing

comment:3 Changed on 08/16/2016 at 08:20:08 AM by abpbot

A commit referencing this issue has landed:
Fixes 4331, 4332 - WebSocket.length and instanceof WebSocket

comment:4 Changed on 08/16/2016 at 08:22:29 AM by kzar

  • Cc Ross scheer added
  • Milestone set to Adblock-Plus-1.12.2-for-Chrome-Opera-Safari
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/22/2016 at 08:02:36 AM by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • When entering the above command in the Java console I get the following:

Chrome 52

comment:6 Changed on 08/22/2016 at 11:47:29 AM by rraceanu

Same results for Safari 8/9 and Opera 39.0.2256.48 - ABP


Last edited on 08/22/2016 at 11:55:16 AM by rraceanu

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.