Opened 6 months ago

Closed 6 months ago

Last modified 4 months ago

#4335 closed defect (fixed)

Adblock Plus should forget pop-ups after the initial load

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #3568 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29349811/

Description (last modified by trev)

Environment

Adblock Plus 2.7.3.4196-beta, Firefox 51.0a1

How to reproduce

  1. Add ||ok.ru^$domain=mail.ru,popup to your Adblock Plus filters.
  2. Go to https://mail.ru/
  3. Click on any news link (in the middle of the page), it will open in a new tab.
  4. In that tab, click the link "Одноклассники" (fourth from left at the very top of the page).

Observed behaviour

The tab is closed. This is a regression from #3568 I think, if a window started out as a pop-up Adblock Plus for Firefox will always treat it as a pop-up - no matter how often navigation occurs.

Expected behaviour

Pop-up blocking should no longer affect navigation in this tab, it's no longer a pop-up.

Change History (6)

comment:1 Changed 6 months ago by trev

  • Description modified (diff)
  • Priority changed from P3 to P2

comment:2 Changed 6 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 6 months ago by abpbot

comment:4 Changed 6 months ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 6 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Pages that open as a popup/new tab that are then navigated in by the user are no longer still treated as popups and automatically closed.

Firefox 38 / 40 / 45 / 48 / 49(Beta) Windows 7

Last edited 5 months ago by Ross (previous) (diff)

comment:6 Changed 4 months ago by fanboy

This patch seemed to stop base64 popup blocking; https://issues.adblockplus.org/ticket/4368

Note: See TracTickets for help on using tickets.