Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4339 closed change (fixed)

Replace M2Crypto by PyCrypto

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By: #4336
Blocking: #4376 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29349869/

Description (last modified by trev)

Background

M2Crypto does not support Python 3 and its documentation is a mess. We should be able to do what we need with PyCrypto which does better on both fronts.

What to change

With #4336 dropping signing of Firefox builds, only Chrome and Safari signing has to be updated.

Integration notes

When integrating this change, you should update README file to mention PyCrypto as optional dependency rather than M2Crypto.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

comment:2 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4339 - Replace M2Crypto by PyCrypto

comment:4 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by sebastian

  • Blocking 4376 added
Note: See TracTickets for help on using tickets.