Opened 3 years ago

Closed 3 years ago

#4341 closed change (fixed)

Make flake8-abp compatible with flake8 3.0

Reported by: sebastian Assignee: sebastian
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, jsonesen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29349889/

Description

Background

flake8 3.0 has just been released, and introduced some breaking changes which broke compatibility with our own flake8 extension. Hence flake8-abp doesn't pass it's own tests anymore. Moreover, projects that use flake8-abp but don't explicitly require flake8 2.x, don't get complete results anymore.

What to change

  • Configure tox to setup environments for both, flake8 2.x and 3.x. Currently it's only using the latest version, which is 3.0 now, however, we have to make sure that both are compatible, for now.
  • Configure tox to explicitly run flake8 on flake8_abp.py and setup.py rather than excluding the tests and build directory. With flake8 3.0, the .tox directory isn't automatically ignored anymore.
  • Fix the test runner by falling back to flake8.api.legacy if flake8.engine cannot be imported.
  • Adapt the entry_points to specify valid error codes as expected by --select/--ignore.

Change History (3)

comment:1 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4341 - Make flake8-abp compatible with flake8 3.0

comment:3 Changed 3 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.