Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4348 closed change (fixed)

Only show adware page notification if visited from the extension

Reported by: saroyanm Assignee: saroyanm
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: juliandoucette, philll, jeen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29350056/

Description

Background

With #3802 we have created an adware page which also show a warning notification, which is not true for the users who are not being linked to the page from the extension notification.

What to change

Make the notification message on the page visible only in case users are visiting the page from the extension's notification, for that we need to have a flag in the URL (query string): ?warning=true.

Change History (9)

comment:1 Changed 3 years ago by saroyanm

  • Owner set to saroyanm

comment:2 Changed 3 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by saroyanm

@Phill, the implementation is ready to launch, can you please let me know if we already linking to this page from the extension ?

comment:4 Changed 3 years ago by philll

We're not, see #3808 and #3809.

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4348 - control adware page warning through url parameter

comment:6 Changed 3 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 follow-up: Changed 3 years ago by juliandoucette

  • Cc jeen added

Note: Jeen wanted to know if we link to this page anywhere because it affects her priorities.

comment:8 in reply to: ↑ 7 Changed 3 years ago by saroyanm

Replying to juliandoucette:

Note: Jeen wanted to know if we link to this page anywhere because it affects her priorities.

We currently only linking from the social media post, but not extensions.

comment:9 Changed 3 years ago by juliandoucette

@Jeen Google does index public Social Media posts and may index this page as a result (even though it appears they have not yet).

Note: See TracTickets for help on using tickets.