Changes between Version 1 and Version 3 of Ticket #4351


Ignore:
Timestamp:
08/23/2016 08:52:17 AM (3 years ago)
Author:
kzar
Comment:

Robert has noticed there are actually exceptions being displayed, I've updated the issue. Certainly doesn't look like a recent regression in any case.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4351

    • Property Cc sebastian Ross added
  • Ticket #4351 – Description

    v1 v3  
    11=== Environment === 
    22Safari 6.0 (doesn't occur on higher Safari versions) 
    3 OS 10.8 
     3OS X 10.8 
    44ABP 1.21.1.1644 / 1.21.1 
    55Easylist and AA 
    6 Viewing youtube video with Flash player. 
    76 
    87=== How to reproduce === 
     
    109 2. Might need to navigate to other videos from the sidebar to get an ad. 
    1110 
    12  
    1311=== Observed behaviour === 
    14 Pre-roll video ad is displayed 
     12Pre-roll video ad is displayed. 
    1513 
    1614=== Expected behaviour === 
    1715Video ads should be blocked. 
     16 
     17=== Notes === 
     18- An exception `ReferenceError: Can't find variable: History` is being [https://usercontent.irccloud-cdn.com/file/wR7B8Bm7/Safari.jpg displayed in the console]. Only when Adblock Plus is installed and only for YouTube. 
     19- It seems likely [https://github.com/adblockplus/adblockpluschrome/blob/9fe6440/safari/include.youtube.js#L99-L104 this line in safari/include.youtube.js] is to blame, and that was committed in 2014.