Opened 3 years ago

Closed 3 years ago

#4374 closed change (fixed)

Make the Python code that is part of jsHydra comply to our coding practices

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By: #4373
Blocking: #4375 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29350244

Description (last modified by sebastian)

Background

In #4373 we started to clean up the Python code of jsHydra, added a tox.ini and support for Python 3. However, as opposed to most of our Python code, we don't run flake8 there yet. And during the port to Python 3, it turned out that there are still a few quality issues with that code.

What to change

Make the tox.ini in the jshydra repository run flake8 with the pep8-naming and flake8-abp, and fix any reported issue.

Change History (4)

comment:1 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Blocking 4375 added

comment:4 Changed 3 years ago by sebastian

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.