Opened 3 years ago

Closed 3 years ago

#4375 closed change (fixed)

Update dependency from buildtools on jshydra for Python 3 support

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By: #4373, #4374
Blocking: #4047, #4376 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29350277

Description (last modified by kzar)

Background

With #4373 Python 3 support has been added to jshydra. Further improvements under the hood have been implemented with #4374. (In #4353 we have also removed some non-standard and unused JavaScript code.) So before we can port buildtools to Python 3, we have to update jshydra.

What to change

  • Update the dependencies file to refer to the revisions that include the mentioned changes.
  • Adapt for API changes: doRewrite(files, args) from jshydra.abp_rewrite has been renamed to rewrite_js(args) where args refers to the raw arguments passed to jshydra now.

Change History (6)

comment:1 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Blocking 4047 added

comment:3 Changed 3 years ago by sebastian

  • Blocking 4376 added

comment:4 Changed 3 years ago by kzar

  • Description modified (diff)

comment:5 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4375 - Updated jshydra dependency for Python 3 support

comment:6 Changed 3 years ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.