Opened 4 years ago

Last modified 4 years ago

#4375 closed change

Update dependency from buildtools on jshydra for Python 3 support — at Version 1

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Blocked By: #4373, #4374
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29350277

Description

Background

With #4373 Python 3 support has been added to jshydra. Further improvements under the hood have been implemented with #4374. So before we can port buildtools to Python 3, we have to update jshydra.

What to change

  • Update the dependencies file to refer to the revisions that include the mentioned changes.
  • Adapt for API changes: doRewrite(files, args) from jshydra.abp_rewrite has been renamed to rewrite_js(args) where args refers to the raw arguments passed to jshydra now.

Change History (1)

comment:1 Changed 4 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.