Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4376 closed change (fixed)

Update buildtools dependency

Reported by: sebastian Assignee: sebastian
Priority: P3 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #4047, #4339, #4340, #4375, #4382
Blocking: #4429 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29350286

Description (last modified by sebastian)

Background

Most notably, this dependency update improves the way jshydra (i.e the [convert_js] section) can be configured (#4047).

Moreover, we did some improvements under the hood, mostly to prepare for Python 3 (#4339, #4375, #4382), however we are not there yet. And xar is no longer required to generate Safari builds (#4340).

What to change

  • Update the dependencies file to refer to the revisions that include the mentioned changes.
  • Adapt the [convert_js] section in the metadata.* files for the new format.
  • Update the README: We no longer depend on xar and M2Crypto, but use PyCrypto instead now.

Hints for testers

  • The new mechanism to configure JavaScript modules is inevitably changing the order of the modules. This should not be a problem, but who knows. In particular the code that is only used on either Chrome/Safari is effected (e.g. popup blocking, the devtools panel and uninstallation page on Chrome, and Content Blocker support on Safari).
  • We also replaced the crypto library, which might effect our self-signed development builds for Chrome and Safari.

Change History (7)

comment:1 Changed 3 years ago by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 3 years ago by sebastian

  • Blocked By 4382 added
  • Description modified (diff)

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4376 - Updated buildtools dependency

comment:4 Changed 3 years ago by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 years ago by kzar

  • Blocking 4429 added

comment:6 Changed 3 years ago by rraceanu

No issues encountered, verified on ABP version 1.12.2.1670, 1.12.1.1630, 1.12.0.1620, platforms Chrome 45, 54, Opera 35, 40 and Safari 7, 9.

Last edited 3 years ago by rraceanu (previous) (diff)

comment:7 Changed 3 years ago by rraceanu

  • Verified working set
Note: See TracTickets for help on using tickets.