Opened 3 years ago

Last modified 23 months ago

#4384 closed defect

ABP Detection not working on Safari — at Version 6

Reported by: esanchez Assignee:
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: kzar, sebastian, arthur, kvas Blocked By:
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)

Environment

OS X 10.11, Safari 9, Adblock Plus 1.12.2(?)
EasyList and Acceptable ads subscriptions enabled.

How to reproduce

  1. Browse to http://gamerant.com/6-best-upcoming-vr-horror-games-666/
  2. Open the developer console / network connections tab.

Observed behaviour

  • srv.yavli.com/px.gif?ch=1 loads successfully.
  • srv.yavli.com/px.gif?ch=2 loads successfully.

Expected behaviour

  • srv.yavli.com/px.gif?ch=1 loads successfully.
  • srv.yavli.com/px.gif?ch=2 should be blocked.

Notes

These are apparently the relevant filters in exceptionrules.txt

||srv.yavli.com/px.gif?ch=2&rn=$domain=destructoid.com|gamerant.com|aplus.com|newser.com
@@||srv.yavli.com/px.gif?ch=1&rn=$domain=destructoid.com|gamerant.com|aplus.com|newser.com

Change History (7)

Changed 3 years ago by esanchez

Safari ABP preferences Panel

comment:1 follow-up: Changed 3 years ago by kzar

  • Cc kzar sebastian added; d.barker@… sebastian@… removed
  • Description modified (diff)

Thanks for filing the issue.

I have corrected the usernames on CC, if you install the Eyeo Helpers extension you'll be given better suggestions and it'll be easier to get those right. Trac is quite bad in that regard.

I have also tidied up the description but some clarification is still required:

  • What version of Safari and Adblock Plus are you using?
  • Are you using any filter subscriptions? If so what are they? (That includes the Acceptable Ads exception subscription.)
  • Are those filters you've listed in the subscriptions you have enabled?
  • Should srv.yavli.com/px.gif?ch=1 also be blocked?

comment:2 Changed 3 years ago by arthur

  • Cc arthur added

comment:3 Changed 3 years ago by esanchez

  • Description modified (diff)
  • Summary changed from Filter rule being ignored in Safari on gamerant.com to ABP Detection not working on Safari -- All sites possible affected

comment:4 in reply to: ↑ 1 Changed 3 years ago by esanchez

Thanks for fixing and giving suggestions.

To answer the questions:

What version of Safari and Adblock Plus are you using?

I tested using on Browserstak using osX Mavericks with Safari 7.1 and saw the same issue.


We also tested on webmate, however we did not write down the version, we believe it was Safari 9.1, but webmate is down now so we will confirm later. What I do know is we downloaded ABP for this specific test so ABP version should be latest.


I also tested on Mario's MacBook, but I did not find him so I will confirm later.


Are you using any filter subscriptions? If so what are they? (That includes the Acceptable Ads exception subscription.)

Just easy list and Exception list

Are those filters you've listed in the subscriptions you have enabled?
Should srv.yavli.com/px.gif?ch=1 also be blocked?

The filters listed are already in the exceptions list.

srv.yavli.com/px.gif?ch=1 should load, srv.yavli.com/px.gif?ch=2 should be blocked

comment:5 Changed 3 years ago by esanchez

Got versions used on WebMate: OS X 10.11 Safari 9, Latest ABP (Still can not run the VM due to some errors on webmate's side)

comment:6 Changed 3 years ago by kzar

  • Description modified (diff)
  • Summary changed from ABP Detection not working on Safari -- All sites possible affected to ABP Detection not working on Safari

When you say latest ABP do you mean the latest development build or the latest release? (I'll assume you meant the latest release 1.12.2 for now, but my point is that you need to specify the actual version numbers/names when filing issues. We need them in order to reproduce problems, which is the first step in fixing them.)

Also please omit speculation like "X might be the case" in issue descriptions, stick to concrete facts. The primary purpose of the issue description for bugs like this is to help the developer reproduce the problem. (You can add a notes or references section to the bottom of the description if you like with extra notes or references if you like.)

Anyway this issue is looking good now, thanks for your patience with it. I'll now try to reproduce the problem.

Note: See TracTickets for help on using tickets.