Changes between Initial Version and Version 3 of Ticket #4386


Ignore:
Timestamp:
08/31/2016 02:42:11 PM (3 years ago)
Author:
trev
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4386

    • Property Priority changed from Unknown to P1
    • Property Ready set
    • Property Owner set to trev
    • Property Summary changed from different behaviour in ABP firefox / chrome regarding whitelisting domains to Document domain determined incorrectly after a redirect
  • Ticket #4386 – Description

    initial v3  
    2323 
    2424on forum: https://adblockplus.org/forum/viewtopic.php?f=10&t=48270 
     25 
     26=== Background === 
     27 
     28`chrome.webNavigation.onBeforeNavigate` isn't being triggered after the redirect, it's merely being triggered for the original URL. It seems that we are using the wrong callback here - we shouldn't get the original URL in the first place because there is no document associated with it. Also, I suspect that `onBeforeNavigate` doesn't actually mean that the previous document is unloaded or that the navigation will definitely occur. 
     29 
     30=== What to change === 
     31The `chrome.webNavigation.onCommitted` callback seems more appropriate here, as this one will only fire when the current document is replaced - which is what we need.