Opened 3 years ago

Closed 2 years ago

#4401 closed defect (fixed)

Typos in https://adblockplus.org/en/filters#whitelist

Reported by: diau Assignee: erick
Priority: P4 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: lisabielik Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29370746/

Description (last modified by juliandoucette)

How to reproduce

  1. Go to https://adblockplus.org/en/filters#whitelist
  2. Read first sentence to find typos. See below.

...

What to change

from

Sometimes you will notice that one of your filters that is usually working quite well blocks in some case blocks something that it shouldn't be blocking.

to

Once in a while you may notice that one of your filters, that normally works well, is blocking something that it shouldn't block.

Change History (13)

comment:1 Changed 3 years ago by greiner

  • Component changed from Unknown to Websites

comment:2 Changed 3 years ago by juliandoucette

  • Cc lisa added

comment:3 Changed 3 years ago by juliandoucette

  • Priority changed from Unknown to P3

Verified. @lisa can you have a look?

comment:4 Changed 3 years ago by juliandoucette

  • Cc lisabielik added; lisa removed

comment:5 Changed 3 years ago by lisabielik

This whole page is a mess. However, yes, that sentence needs changed.

Please change to:

"Once in a while you may notice that one of your filters, that normally works well, is blocking something that it shouldn't block."

comment:6 Changed 3 years ago by juliandoucette

  • Keywords goodfirstbug added
  • Priority changed from P3 to P4
  • Ready set

@lisabielik feel free to take this one if you want.

comment:7 Changed 3 years ago by juliandoucette

  • Keywords textchange added

comment:8 Changed 3 years ago by juliandoucette

  • Keywords textchange removed

comment:9 Changed 3 years ago by erick

  • Owner set to erick
  • Review URL(s) modified (diff)

comment:10 Changed 3 years ago by erick

  • Status changed from new to reviewing

comment:11 Changed 3 years ago by juliandoucette

  • Description modified (diff)

Please update the description when the spec is changed in comments.

comment:12 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 4401 - Amend typos in /filters/#whitelist

comment:13 Changed 2 years ago by erick

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.