Opened 3 years ago

Closed 2 years ago

#4409 closed defect (rejected)

Toolbar icon is too large on older Firefox version and high-DPI screens

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29352637/

Description

Environment

Adblock Plus 2.7.3.4198-beta, Firefox 38, Mac OS X 10.11 with Retina screen

How to reproduce

  1. Start Firefox, look at the ABP toolbar icon.

Observed behaviour

Toolbar icon is too wide, stretching the entire toolbar button.

Expected behaviour

Toolbar icon size is 32x32, like in newer Firefox versions.

Change History (10)

comment:1 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 3 years ago by diceman2037

has broken the large and small icons on firefox 44 @ 125% dpi

all i see is the drop down arrow now.

tested in existing and new profile

Last edited 3 years ago by diceman2037 (previous) (diff)

comment:6 Changed 3 years ago by trev

  • Milestone Adblock-Plus-for-Firefox-next deleted
  • Priority changed from P3 to P4
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening since the fix has been rolled back - on Windows that icon has paddings, so the resulting icon size is wrong (see #4445). As things stand, I don't really see a solution which would work reliably everywhere.

comment:7 Changed 3 years ago by juliandoucette

I think this issue should be a higher priority. Picky users (like me) will install another ad blocker based on how good the toolbar (and menu) icon looks alone. I suspect that the product team would back me up on this.

comment:8 Changed 3 years ago by trev

This issue affects Firefox 40 and below I think, current release is Firefox 49 - and it might be Mac-only, I didn't check. Why should this issue have a higher priority?

Note also that resolving this issue appears to be non-trivial to say the least - at least without breaking things on other platforms.

comment:9 Changed 3 years ago by juliandoucette

Note also that resolving this issue appears to be non-trivial to say the least - at least without breaking things on other platforms.

Noted.

This issue affects Firefox 40 and below I think, current release is Firefox 49 - and it might be Mac-only, I didn't check. Why should this issue have a higher priority?

It shouldn't.

---

I think I misinterpreted the issue and spoke too soon here. I'm sorry @trev.

comment:10 Changed 2 years ago by trev

  • Resolution set to rejected
  • Status changed from reopened to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

Note: See TracTickets for help on using tickets.