Opened 3 years ago

Closed 11 months ago

#4413 closed change (fixed)

Merge formmail.py and formmail2.py

Reported by: kvas Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas Blocked By: #4377, #4421, #4422, #4423, #4424
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29984580

Description (last modified by kvas)

Background

We've developed a configurable form to email service for Acceptable Ads website (#4377). It's now possible to implement the functionality of formmail.py via configuring formmail2.py in a specific way, so we can do that, eliminate formmail.py and rename formmail2.py to formmail.py (taking care of the relevant configuration changes).

What to change

Here's the outline of the migration path that we'll need to take (detailed configuration snippets to be added):

  1. Migrate eyeo.com to "formmail2": #4421.
  2. Replace the old implementation of "formmail" with "formmail2" and add an alias: #4422.
  3. Migrate eyeo.com and acceptableads.org to use "formmail": #4423.
  4. Remove the alias: #4424.
  5. Document the configuration and usage of formmail to facilitate future reuse. Add README.md to sitescripts/formmail with the explanation aimed at a person configuring the server. Add comments and docstrings to formmail.py as appropriate. This can be done separately or as part of steps 2 or 4.

Change History (13)

comment:1 Changed 3 years ago by kvas

  • Description modified (diff)

comment:2 Changed 3 years ago by kvas

  • Blocked By 4421 added

comment:3 Changed 3 years ago by kvas

  • Description modified (diff)

comment:4 Changed 3 years ago by kvas

  • Blocked By 4422 added

comment:5 Changed 3 years ago by kvas

  • Blocked By 4423 added

comment:6 Changed 3 years ago by kvas

  • Blocked By 4424 added

comment:7 Changed 3 years ago by kvas

  • Description modified (diff)

comment:8 Changed 3 years ago by kvas

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:9 Changed 11 months ago by rhowell

  • Cc kvas added
  • Owner set to rhowell

comment:10 Changed 11 months ago by rhowell

Since web.eyeo.com is no longer in use, and therefore formmail.py is no longer in use, maybe it makes sense to update this ticket. I'd suggest closing 4421-4424, and just using this issue to track the changes.

Last edited 11 months ago by rhowell (previous) (diff)

comment:11 Changed 11 months ago by rhowell

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:12 Changed 11 months ago by abpbot

A commit referencing this issue has landed:
Issue 4413 - Merge formmail.py and formmail2.py

comment:13 Changed 11 months ago by rhowell

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.