Opened 3 years ago

Closed 9 months ago

#4422 closed change (duplicate)

Replace the old implementation of "formmail" with "formmail2" and add an alias

Reported by: kvas Assignee:
Priority: P3 Milestone:
Module: Sitescripts Keywords: goodfirstbug
Cc: Blocked By: #4421
Blocking: #4413, #4423 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kvas)

Background

See #4413. This is the second step that should only be pushed after #4421 is deployed.

What to change

  1. Replace the content of formmail.py with the content of formmail2.py.
  2. Make formmail configuration process use [formmail] section of the configuration and fall back to [formmail2] if that is not present.
  3. Replace the content of formmail2.py with from . import formmail.
  4. Delete eyeo.mail from sitescripts/formmail/template.
  5. Remove formmail tests, put formmail tests into test_formmail.py and adjust them to import formmail instead of formmail2.

Change History (7)

comment:1 Changed 3 years ago by kvas

  • Description modified (diff)

comment:2 Changed 3 years ago by kvas

  • Blocking 4423 added

comment:3 Changed 3 years ago by kvas

  • Description modified (diff)

comment:4 Changed 3 years ago by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 3 years ago by sebastian

  • Keywords goodfirstbug added

comment:6 Changed 9 months ago by rhowell

Since we stopped using web.eyeo.com, this change has become much less complicated. Closing this ticket; the change will be tracked in #4413.

comment:7 Changed 9 months ago by rhowell

  • Resolution set to duplicate
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.