Opened 15 months ago

Closed 14 months ago

Last modified 13 months ago

#4429 closed change (fixed)

Update Js Shell and related dependencies

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, kzar, rraceanu Blocked By: #4353, #4376
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29353003/

Description (last modified by kzar)

Background

For issue #4353 we have been working towards updating Js Shell. Since we were previously using quite an old version this has required changes to adblockpluschrome, adblockpluscore, adblockplustests to remove non-standard / deprecated syntax that's no longer supported. We've also obviously needed to make changes to the jshydra repository and therefore the buildtools repository.

What to change

  • Update the following dependencies:
    • adblockpluscore to hg:103fdc164738 git:199dffd. (Which also includes an unrelated change to Firefox-specific element hiding code.)
    • adblockplustests to hg:592c6d74a9cc git:cfbe11f. (Which also includes a few unrelated buildtools / metadata changes.)
    • buildtools to hg:400d571dc98d git:ee6620c. (Which also includes an unrelated change to exception catching syntax.)
  • Add adblockpluscore/lib/coreUtils.js to lib/adblockplus.js in the [convert_js] section of metadata.common.

Hints for testers

This is not one that you can easily test directly, other than to check the extension works as normal! If this had gone wrong it would likely completely break the extension.)

Change History (7)

comment:1 Changed 15 months ago by kzar

  • Description modified (diff)

comment:2 Changed 15 months ago by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 14 months ago by abpbot

A commit referencing this issue has landed:
Issue 4429 - Update dependencies for latest Js Shell

comment:4 Changed 14 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 14 months ago by kzar

  • Ready set

comment:6 Changed 13 months ago by kzar

  • Cc rraceanu added
  • Description modified (diff)

(Added a note about testing Robert.)

comment:7 Changed 13 months ago by rraceanu

  • Verified working set

No issues encountered on ABP version 1.12.2.1670, Chrome 45, 51, 54, Opera 35, 40 and Safari 7, 9.

Note: See TracTickets for help on using tickets.