Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#443 closed defect (fixed)

Popups aren't blocked anymore when blocking the URL it redirects to

Reported by: arthur Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: smultron45@…, trev, manvel@… Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29329404/

Description

Environment

Firefox 29
ABP 2.6.0.3807
EasyList
Windows 8.1 Pro x64 Update 1

How to reproduce

  1. Go to http://slickvid.com/gwush16s7drt
  2. Click on the white background

Observed behaviour

A popup/popunder appears without redirecting to the ad URL (http://cdn.directrev.com/js/direct?s=S0002219 in my case) because it is blocked by

||directrev.com^$popup,third-party

The popup/popunder isn't blocked/closed though.

Expected behaviour

Not exactly sure when this changed but ABP blocked popups even if the immediate pop-up URL isn't blocked but the subsequent one(s).

Change History (13)

comment:1 Changed 4 years ago by mapx

  • Cc smultron45@… added

comment:2 Changed 4 years ago by mapx

did you try

||goo.gl^$popup

?

comment:3 Changed 4 years ago by trev

  • Cc trev added

comment:4 Changed 4 years ago by arthur

@mapx
Yes, this works as expected. However, popups were still closed/blocked before even if it's not the very first popup URL that is blocked.

comment:5 Changed 4 years ago by philll

  • Priority changed from P3 to P2

I'm wondering, whether we should set any bugs of kinda-core functionality to lower than P2

comment:6 Changed 4 years ago by saroyanm

  • Cc manvel@… added
  • Platform set to Unknown

comment:7 Changed 4 years ago by philll

  • Platform changed from Unknown to Firefox

comment:8 Changed 3 years ago by trev

  • Blocked By 3208 added
  • Tester set to Unknown

Will be fixed as side-effect of #3208.

comment:9 Changed 3 years ago by trev

  • Owner set to trev

comment:10 Changed 3 years ago by trev

  • Blocked By 3208 removed
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Fixed in a separate commit after all.

comment:11 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 3 years ago by Ross

I've tried 10+ SlickVid URL's and they are all 404/video not found, and those pages don't appear to push any advertising/popups. Does anyone have a working URL?

comment:13 Changed 3 years ago by arthur

I think we can use this testcase (from bug 467514).

I added this filter |https://www.google.$popup and clicked on "Click here". The popup/new window was closed as expected (old behaviour).

Note: See TracTickets for help on using tickets.