Opened 3 years ago

Last modified 16 months ago

#4439 new change

Make the feedback link in the Adblock Browser preferences point to about:feedback again

Reported by: fhd Assignee:
Priority: P3 Milestone:
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: #4174 Platform: Adblock Browser for Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Back in the day, after we had disabled about:feedback, we changed the feedback link under preferences to point to our Google+ beta community (#2354). Later, we replaced this with a redirect (#2479). However, since we reactivated about:feedback, we can revert those changes again.

What to change

Change the target of the settings item Give feedback under Settings -> Adblock Browser back to about:feedback. The code in question should be identical to the upstream (i.e. Mozilla) version again.

Change History (5)

comment:1 Changed 22 months ago by jwangenheim

  • Owner set to jwangenheim

comment:2 Changed 22 months ago by jwangenheim

Since Firefox 47 about:feedback was replaced with page hosted on input.moziall.org (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1239513). The url also contains MOZ_UPDATE_CHANNEL and MOZ_APP_VERSION.

@fhd
I guess due to this change, the last sentence in the ticket is not valid anymore and we will just link to about:feedback again?

comment:3 Changed 22 months ago by fhd

How I understand that bug you linked to, about:feedback itself is not local anymore but pointing to a page hosted on input.mozilla.org. That means that we have to leave this link alone.

It also means that we have to either:

a) Replace about:feedback with a local page.
b) Remove about:feedback, and the mechanism that automatically opens it after a few launches of the app.

But we should create a separate issue for that.

comment:4 Changed 22 months ago by jwangenheim

  • Blocking 4174 added
  • Ready unset

comment:5 Changed 16 months ago by jwangenheim

  • Owner jwangenheim deleted
Note: See TracTickets for help on using tickets.