Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#4440 closed defect (fixed)

[HA crash] iOS9 breaking NSHTTPURLResponse Swift nilness contract

Reported by: pavelz Assignee:
Priority: P2 Milestone: Adblock-Browser-for-iOS-1.5.1
Module: Adblock-Browser-for-iOS Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



ABB 1.5.0 Appstore release

How to reproduce


Observed behaviour


Expected behaviour

No crash

Change History (6)

comment:1 Changed 4 years ago by pavelz

The stacktrace claims to crash on null pointer here
but because it's being called from here
and details is being explicitly unwrapped in condition, it's more likely the next line
where it's very possible that the calling code sends nil for httpResponse.allHeaderFields
which is contracted to be non-optional by NSHTTPURLResponse API

comment:2 Changed 4 years ago by pavelz

Last edited 4 years ago by pavelz (previous) (diff)

comment:4 Changed 4 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 4 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-1.5.1

Added to Milestone 1.5.1

comment:6 Changed 4 years ago by mario

  • Priority changed from Unknown to P2

Adjusted priority

Note: See TracTickets for help on using tickets.