Opened 3 years ago

Closed 3 years ago

#4442 closed change (fixed)

Cache class and ctors references in JNI_Load/UnLoad

Reported by: asmirnov Assignee: asmirnov
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords: goodfirstbug
Cc: rjeschke Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29354787/

Description

Background

Most java instances are created in jni-glue classes and java class/ctors references are cached in c++ ctors. This is more data-safe approach (actually i like it) but it can cause low performance because of lot's of invocations or unneeded invocations.

Discussed during code review:
https://codereview.adblockplus.org/29345737/#msg11

What to change

Migrate from caching global references to classes/methods to JNI_OnLoad/UnLoad for performance reason.

Change History (4)

comment:1 Changed 3 years ago by fhd

  • Cc rjeschke added
  • Keywords goodfirstbug added
  • Priority changed from P4 to P3

comment:2 Changed 3 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad

comment:4 Changed 3 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.