Opened on 09/16/2016 at 06:22:39 AM

Closed on 11/21/2016 at 10:57:04 AM

#4442 closed change (fixed)

Cache class and ctors references in JNI_Load/UnLoad

Reported by: asmirnov Assignee: asmirnov
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords: goodfirstbug
Cc: rjeschke Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



Most java instances are created in jni-glue classes and java class/ctors references are cached in c++ ctors. This is more data-safe approach (actually i like it) but it can cause low performance because of lot's of invocations or unneeded invocations.

Discussed during code review:

What to change

Migrate from caching global references to classes/methods to JNI_OnLoad/UnLoad for performance reason.

Attachments (0)

Change History (4)

comment:1 Changed on 09/16/2016 at 07:59:56 AM by fhd

  • Cc rjeschke added
  • Keywords goodfirstbug added
  • Priority changed from P4 to P3

comment:2 Changed on 09/26/2016 at 10:23:46 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 11/21/2016 at 10:54:14 AM by abpbot

A commit referencing this issue has landed:
Issue 4442 - Cache class and ctors references in JNI_Load/UnLoad

comment:4 Changed on 11/21/2016 at 10:57:04 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from asmirnov.
Note: See TracTickets for help on using tickets.