Changes between Initial Version and Version 4 of Ticket #4445


Ignore:
Timestamp:
10/06/2016 01:03:13 PM (3 years ago)
Author:
trev
Comment:

I rolled back the change in question with https://hg.adblockplus.org/adblockplus/rev/14e4e1982152 - it seems that the fix only works on OS X and breaks things on Windows. Currently I don't see any approach that would work with both, the platform-specific Firefox themes are too different.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4445

    • Property Status changed from new to closed
    • Property Cc mapx added
    • Property Priority changed from Unknown to P1
    • Property Milestone changed from to Adblock-Plus-for-Firefox-next
    • Property Ready set
    • Property Resolution changed from to fixed
  • Ticket #4445 – Description

    initial v4  
    1616* The drop down icon is still clickable  
    1717* Also reproducible with Firefox 48.0.2 
     18 
     19=== Background === 
     20In #4409 we set a fixed width and height for the toolbar icon. Turned out, on Windows this toolbar icon has paddings in order to accommodate the dropdown arrow - the resulting content size gets too small because of that. Applying `box-sizing: content-box` to the element doesn't show any effect, probably because of XUL specifics.