Opened 5 months ago

Closed 5 months ago

Last modified 4 months ago

#4448 closed change (fixed)

Use 'websocket' type for WebSocket connections

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, trev, rraceanu Blocked By: #4387
Blocking: #4372 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29353434/

Description (last modified by kzar)

Background

In issue #4387 we added the websocket request type, now we want to use from adblockpluschrome.

What to change

  • Update the adblockpluscore dependency to hg:d0d7a9d27bf7 git:b2333b7. (This does not include any other changes.)
  • Change lib/requestBlocker.js to consider WebSocket connections as being of the type websocket instead of other.

Hints for testers

To test this on Safari you could do the following:

  1. Browse to http://www.websocket.org/echo.html
  2. Add the filter: ||echo.websocket.org/$websocket
  3. Click "Connect"

If the connection is immediately disconnected with an Error message displayed in the text area then the WebSocket was successfully blocked.

Change History (8)

comment:1 Changed 5 months ago by kzar

  • Status changed from new to reviewing

comment:2 Changed 5 months ago by kzar

  • Description modified (diff)

comment:3 Changed 5 months ago by trev

  • Sensitive unset

comment:4 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 4448 - Use websocket request type

comment:5 Changed 5 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 4 months ago by rraceanu

Type successfully changed to "Websocket", verified on ABP version 1.12.2.1670, Chrome 41,45,51,54.

comment:7 Changed 4 months ago by kzar

  • Cc rraceanu added
  • Description modified (diff)

(Added some hints about how to test this on Safari Robert.)

comment:8 Changed 4 months ago by rraceanu

  • Verified working set

Verified on Safari 8, 9 and Opera 35, 40, ABP version 12.2.1670, type successfully changed to Websocket.

Note: See TracTickets for help on using tickets.