Opened on 09/20/2016 at 10:03:46 AM

Closed on 09/20/2016 at 12:06:28 PM

Last modified on 10/25/2016 at 11:00:19 AM

#4448 closed change (fixed)

Use 'websocket' type for WebSocket connections

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, trev, rraceanu Blocked By: #4387
Blocking: #4372 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

Description (last modified by kzar)


In issue #4387 we added the websocket request type, now we want to use from adblockpluschrome.

What to change

  • Update the adblockpluscore dependency to hg:d0d7a9d27bf7 git:b2333b7. (This does not include any other changes.)
  • Change lib/requestBlocker.js to consider WebSocket connections as being of the type websocket instead of other.

Hints for testers

To test this on Safari you could do the following:

  1. Browse to
  2. Add the filter: ||$websocket
  3. Click "Connect"

If the connection is immediately disconnected with an Error message displayed in the text area then the WebSocket was successfully blocked.

Attachments (0)

Change History (8)

comment:1 Changed on 09/20/2016 at 10:04:05 AM by kzar

  • Status changed from new to reviewing

comment:2 Changed on 09/20/2016 at 10:56:03 AM by kzar

  • Description modified (diff)

comment:3 Changed on 09/20/2016 at 11:12:33 AM by trev

  • Sensitive unset

comment:4 Changed on 09/20/2016 at 12:05:20 PM by abpbot

A commit referencing this issue has landed:
Issue 4448 - Use websocket request type

comment:5 Changed on 09/20/2016 at 12:06:28 PM by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 10/25/2016 at 03:14:09 AM by rraceanu

Type successfully changed to "Websocket", verified on ABP version, Chrome 41,45,51,54.

comment:7 Changed on 10/25/2016 at 08:20:39 AM by kzar

  • Cc rraceanu added
  • Description modified (diff)

(Added some hints about how to test this on Safari Robert.)

comment:8 Changed on 10/25/2016 at 11:00:19 AM by rraceanu

  • Verified working set

Verified on Safari 8, 9 and Opera 35, 40, ABP version 12.2.1670, type successfully changed to Websocket.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.