Opened 3 years ago

Last modified 3 years ago

#4448 closed change

Use 'websocket' type for WebSocket connections — at Version 2

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, trev, rraceanu Blocked By: #4387
Blocking: #4372 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29353434/

Description (last modified by kzar)

Background

In issue #4387 we added the websocket request type, now we want to use from adblockpluschrome.

What to change

  • Update the adblockpluscore dependency to hg:d0d7a9d27bf7 git:b2333b7. (This does not include any other changes.)
  • Change lib/requestBlocker.js to consider WebSocket connections as being of the type websocket instead of other.

Change History (2)

comment:1 Changed 3 years ago by kzar

  • Status changed from new to reviewing

comment:2 Changed 3 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.