Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4449 closed change (fixed)

Use 'websocket' type for WebSocket connections

Reported by: kzar Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By: #4387
Blocking: #4372 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29353444/

Description (last modified by trev)

Background

In issue #4387 we added the websocket request type, now we want to use from adblockplus.

What to change

  • Update adblockpluscore dependency to revision d0d7a9d27bf7.
  • Add WEBSOCKET to supported types.
  • Add the necessary string to display websocket connections in Blockable items list.

As the dependency update also imports that changes from #4353, updating file mapping to add lib/coreUtils.js to the package is also necessary.

Change History (8)

comment:1 Changed 3 years ago by kzar

  • Sensitive set

comment:2 Changed 3 years ago by trev

  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set
  • Sensitive unset

comment:3 Changed 3 years ago by trev

  • Owner set to trev

comment:4 Changed 3 years ago by trev

  • Description modified (diff)

comment:5 Changed 3 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 4449 - Use 'websocket' type for WebSocket connections

comment:7 Changed 3 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Working as expected using both $websocket and |wss:// filters. Hits are counted, appears in blockable items list. Tested against https://www.websocket.org/echo.html and those adult sites that use websockets to stream in ads.

ABP 2.7.3-4214-beta
Firefox 39 / 45 / 49 / 52-Nightly / Windows 7

Note: See TracTickets for help on using tickets.