Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#4456 closed change (fixed)

Roll back UI changes for ABP version displaying

Reported by: pavelz Assignee:
Priority: P3 Milestone: Adblock-Browser-for-iOS-1.5.1
Module: Adblock-Browser-for-iOS Keywords:
Cc: mario Blocked By:
Blocking: Platform: Adblock Browser for iOS
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

Description

Background

#4400 Display ABP extension version in About page
was implemented for the next intended ABB release.
However, per weekly call decision
https://docs.google.com/document/d/1sc3ir9c1bsnasgKgZdpRxUXtv4PgRxjvlC78vGHmzqc
an iOS10-crashing hotfix is required, and #4400 depends on changes in ABP for which the
pull request was not reviewed/accepted yet
https://bitbucket.org/pavel-zdenek/adblockplusadblockbrowserios/pull-requests/2

Furthermore, #4400 induced change in texting which would require translation roundtrip, further delaying the hotfix.

What to change

  1. Roll back the "rigged" ABP 1.12.2.4400 to original 1.12.2.1645
  2. Roll back the UI surface changes
  3. Leave the backend plumbing in place

Change History (4)

comment:2 Changed 3 years ago by mario

  • Milestone set to Adblock-Browser-for-iOS-1.5.1
  • Priority changed from Unknown to P3

comment:3 Changed 3 years ago by pavelz

  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 3 years ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • ABP version is no longer displayed in the About section.

ABP 1.5.1 (1137)
iPhone 6s Plus
iOS 9.3.4

Note: See TracTickets for help on using tickets.