Opened 3 years ago

Closed 3 years ago

#4459 closed change (rejected)

xarfile should not expect Crypto.Signature module to be present

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: Automation Keywords:
Cc: sebastian Blocked By:
Blocking: #4340 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

As of #4458 we are now using PyCrypto on the update server. However, it turned out that Ubuntu Precise gets the outdated PyCrypto 2.4.1 version which doesn't have Crypto.Signature module. So updating manifests fails because buildtools.xarfile cannot be imported.

What to change

Crypto.Signature module is only necessary for the buildtools.xarfile.get_signature method. Update server doesn't call this method, it merely needs to decode the certificates. So we can move the import into this method rather than have it at top level.

Change History (5)

comment:1 Changed 3 years ago by abpbot

comment:2 Changed 3 years ago by trev

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 3 years ago by trev

  • Component changed from Sitescripts to Build-and-Release-Tools

comment:4 Changed 3 years ago by trev

  • Resolution fixed deleted
  • Status changed from closed to reopened

Rolled back in https://hg.adblockplus.org/buildtools/rev/6657d71cdccc, this isn't sufficient to support PyCrypto 2.4 on the server so we need to get a newer version there.

comment:5 Changed 3 years ago by trev

  • Resolution set to rejected
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.