Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#4463 closed defect (fixed)

Content blocker unavailable error message

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P1 Milestone: Adblock-Plus-for-Samsung-Browser-1.0.4
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: mario, vickyyu, CraftyDeano Blocked By:
Blocking: #4485 Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29355386/

Description (last modified by diegocarloslima)

In the latest release of Samsung Internet for Android, they changed their behaviour regarding the Content Blocker initialisation. If openFile() call takes too long to complete on the Browser startup, the Content Blocker Unavailable Error is shown. To fix that, we need to immediately return a File, using some previously cached file or a dummy one while we prepare the filter file.

Hints for Testers

This issue has been observed in Samsung Internet versions from 4.0.20-xx to 4.0.30-xx. It has been fixed on version 4.2.x

The error message is shown every time the Samsung Internet app is launched with Adblock Plus for Samsung Browser activated

Change History (9)

comment:1 Changed 4 months ago by diegocarloslima

  • Description modified (diff)
  • Owner set to diegocarloslima
  • Ready set

comment:2 Changed 4 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 4 months ago by diegocarloslima

  • Blocking 4485 added

comment:4 Changed 4 months ago by CraftyDeano

  • Cc CraftyDeano added

comment:5 Changed 3 months ago by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.0.4

comment:6 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 4463 - Content blocker unavailable error message

comment:7 Changed 3 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed 3 months ago by diegocarloslima

  • Description modified (diff)

comment:9 Changed 3 months ago by scheer

  • Tester changed from Unknown to Scheer
  • Verified working set
  • 'Content Blocker Unavailable Error' is no longer shown on app startup.

ABB Android 1.0.4
Android 5.0.2
Android 6.0.1
Galaxy S7
Note 3

Note: See TracTickets for help on using tickets.