Opened on 09/22/2016 at 01:21:02 PM

Closed on 10/04/2016 at 02:23:53 PM

#4464 closed defect (fixed)

updateUpdateManifests script relies on which is no longer there

Reported by: trev Assignee: kvas
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: sebastian, kvas Blocked By:
Blocking: #3759 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)

How to reproduce

  1. Create a clean copy of sitescripts repository.
  2. Run python -m sitescripts.extensions.bin.updateUpdateManifests

Observed behaviour

The script errors out, it attempts to import from module which was removed in #3759.

Expected behaviour

No errors. Currently, this is only working on the server because of a stale android.pyc file.

What to change

Add the get_min_sdk_version() function from the removed module to sitescripts.extensions.bin.updateUpdateManifests, and remove the dead import.

Attachments (0)

Change History (9)

comment:1 Changed on 09/22/2016 at 01:27:04 PM by sebastian

  • Cc kvas added
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 09/22/2016 at 01:28:31 PM by sebastian

  • Component changed from Unknown to Sitescripts

comment:3 Changed on 09/22/2016 at 01:36:51 PM by sebastian

  • Description modified (diff)

comment:4 Changed on 09/22/2016 at 01:42:13 PM by sebastian

  • Description modified (diff)

comment:5 Changed on 09/22/2016 at 01:43:19 PM by sebastian

  • Description modified (diff)

comment:6 Changed on 09/22/2016 at 04:39:11 PM by kvas

  • Owner set to kvas

comment:7 Changed on 09/22/2016 at 04:39:27 PM by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed on 10/04/2016 at 02:21:37 PM by abpbot

comment:9 Changed on 10/04/2016 at 02:23:53 PM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kvas.
Note: See TracTickets for help on using tickets.