Opened 3 years ago

Last modified 3 years ago

#4466 closed change

Update adblockpluscore dependency, replace rsa.js with rsa module — at Version 1

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, trev Blocked By: #4465
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29354778/

Description (last modified by trev)

Background

In #4465 we are migrating rsa.js into adblockpluscore and turning it into a proper module. We now need to remove rsa.js from adblockpluschrome and adapt our code to use that module.

What to change

  • Update the adblockpluscore dependency.
  • Delete adblockpluschrome/lib/rsa.js.
  • Delete qunit/tests/signatures.js.
  • Modify metadata.common to include adblockpluscore/lib/rsa.js, adblockpluscore/lib/jsbn.js and adblockpluscore/lib/rusha.js.
  • Modify any code that uses the verifySignature function to first import the rsa module.

Change History (1)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

I changed the description to include jsbn.js and rusha.js, also added a note on removing tests - these should be moved to adblockpluscore in #4465.

Note: See TracTickets for help on using tickets.