Opened 3 years ago

Last modified 3 years ago

#4466 closed change

Update adblockpluscore dependency, replace rsa.js with rsa module — at Version 5

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-1.12.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: sebastian, trev Blocked By: #4465
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29354778/

Description (last modified by kzar)

Background

In #4465 we are migrating rsa.js into adblockpluscore and turning it into a proper module. We now need to remove rsa.js from adblockpluschrome and adapt our code to use that module.

What to change

  • Update the buildtools dependency to hg:595808987fd9 git:5f8a4c2. (Also includes a change which was immediately backed out.)
  • Update the adblockpluscore dependency to hg:d451a8ff84b9 git:56fcfd1. (Does not include any other changes.)
  • Delete adblockpluschrome/lib/rsa.js, adblockpluschrome/lib/jsbn.js, adblockpluschrome/lib/sha1.js.
  • Delete qunit/tests/signatures.js.
  • Modify metadata.common to include adblockpluscore/lib/rsa.js, adblockpluscore/lib/jsbn.js and adblockpluscore/lib/rusha.js.
  • Modify metadata.common to remove lib/sha1.js , lib/jsbn.js and lib/sha1.js from background and test scripts.
  • Modify lib/whitelisting.js to import verifySignature function from the rsa module.

Change History (5)

comment:1 Changed 3 years ago by trev

  • Description modified (diff)

I changed the description to include jsbn.js and rusha.js, also added a note on removing tests - these should be moved to adblockpluscore in #4465.

comment:2 Changed 3 years ago by trev

  • Description modified (diff)

comment:3 Changed 3 years ago by trev

  • Description modified (diff)

comment:4 Changed 3 years ago by kzar

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 3 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.